clean: Remove uses of native C++ implementation#3378
clean: Remove uses of native C++ implementation#3378comius wants to merge 3 commits intobazel-contrib:mainfrom
Conversation
All uses need to be through rules_cc, because C++ will be removed from Bazel.
comius
force-pushed
the
remove-native-cc-uses
branch
from
b633448 to
0ad5159
Compare
Summary of ChangesHello @comius, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the python/private/cc_helper.bzl file, which was an adapter for accessing Bazel's internal native C++ implementation. This change aligns with the stated goal of migrating to rules_cc as native C++ support is being removed from Bazel. The change is a simple and clean file deletion. Based on the provided context, the file appears to be unused, so its removal is appropriate.
|
This is related to #3367 |
3 participants
All uses need to be through rules_cc, because C++ will be removed from Bazel.